Conversation
failures. The issue is caused by the code checking socket status *after* checking if bytes are available. Bytes may have become available between the last byte available check and the socket status check. This causes us to incorrectly ignore the newly available bytes and return 0 to the caller, which in any blocking/timeout scenario tells the caller no more bytes will ever be available. This was introduced in commit 89b9f10 See also adafruit#151 as a fix for adafruit#135
# Conflicts: # adafruit_wiznet5k/adafruit_wiznet5k_socketpool.py
FoamyGuy
commented
Jan 23, 2026
Contributor
Author
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
This change makes sense and looks good to me. I tested it successfully with the simpletest, httpserver, and aio_post examples from this repo with an Ethernet FeatherWing + Feather RP2350.
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 24, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.4.1 from 7.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#188 from FoamyGuy/pr_171_merge_main > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#178 from fasteddy516/match_core_sockets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #171. I tried to merge main and resolve conflicts in that branch, but library maintainers do not have access to push to the branch so I cannot update the PR.
Will close #171 in favor of this one which has main merged and is all up to date.